nimble/host: Fix for BLE_HS_DBG_ASSERT in adv_set_fields#743
Merged
rymanluk merged 1 commit intoapache:masterfrom Jan 27, 2020
Merged
nimble/host: Fix for BLE_HS_DBG_ASSERT in adv_set_fields#743rymanluk merged 1 commit intoapache:masterfrom
rymanluk merged 1 commit intoapache:masterfrom
Conversation
This is regression after 9583379 nimble/host: Fix checking dst_len in adv_set_fields Function ble_hs_adv_set_fields_mbuf() does not use dst_len which triggers the BLE_HS_DBG_ASSERT For that reason, we have now local variable in the adv_set_fields which is later copied to dst_len if needed.
sjanc
approved these changes
Jan 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is regression after
9583379 nimble/host: Fix checking dst_len in adv_set_fields
Function ble_hs_adv_set_fields_mbuf() does not use dst_len which
triggers the BLE_HS_DBG_ASSERT
For that reason, we have now local variable in the adv_set_fields which
is later copied to dst_len if needed.