nimble/ll: Use jrand48 for pseudo random generator#883
Merged
sjanc merged 1 commit intoapache:masterfrom Nov 17, 2020
Merged
Conversation
benpicco
reviewed
Nov 16, 2020
| @@ -20,6 +20,7 @@ | |||
| #include <stdint.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <stdint.h> | |
| #define _XOPEN_SOURCE | |
| #include <stdint.h> |
to make jrand48() available.
Don't use rand() for for pseudo random generation as this shares global state. Use jrand48 instead and provide wrapper for late initialization. This is to avoid seeding on init beacouse trng might not be accessible yet. This also means LL code will no longer seed stdlib srand() on init as this should be application responsibility anyway.
Style check summaryNo suggestions at this time! |
andrzej-kaczmarek
approved these changes
Nov 16, 2020
This was referenced Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use rand() for for pseudo random generation as this shares global
state. Use jrand48 instead and provide wrapper for late initialization.
This is to avoid seeding on init beacouse trng might not be accessible
yet.
This also means LL code will no longer seed stdlib srand() on init as
this should be application responsibility anyway.