remove platform + put more to nightlies #73
Conversation
There was a problem hiding this comment.
Removing platform is good. Publishing vsix (and possibly Windows installer) to nightlies good.
I would keep all archiving on builds. Nightlies doesn't have zip download for all release artefacts. Also, can't keep forever the right build.
I would actually stop publishing NBMs to nightlies, for now at least. No use unless we can rework the update centre redirects. And I'm not sure about uploading Maven. Takes a lot of time. Why do we need it there?
Maybe better to review after 16 release?
vars/asfMainNetBeansBuild.groovy
Outdated
| } | ||
| // make vsix available to dist to pickup (only for main release) need a maven setup | ||
| sh "ant -f build-${clustername}-temp/java/java.lsp.server build-vscode-ext -Dvsix.version=${vsixversion} -Dmetabuild.branch=${branch}" | ||
| //sh "cp -r build-${clustername}-temp/java/java.lsp.server/build/*.vsix dist/vsix/" |
There was a problem hiding this comment.
Isn't that line needed to archive vsix on build?
|
For maven I would try to get only the zip, as storing artefacts take long time. |
|
@neilcsmith-net not sure we are ok there. |
|
Zip only maven repo on ci-builds good with me. I just download "all files in zip" there anyway. Just should not be on nightlies - can't be locked, gets overwritten, etc. As long as we archive all artefacts on ci-builds that are pushed to nightlies I'm good with the changes. I don't think we should use publish to nightlies as a replacement for the archived artefacts, just as the download source for end users. |
|
you're right, merging this for now. |
2 participants
This is an update to remove the generation of platform.
vsix to nightlies
mavenrepo zipped to nightly
installers to nightlies
if it's ok to merge it would be nice to force a build to test :D.