Reload POM action not working on maven projects

[albilu]

Apache NetBeans version

Apache NetBeans 18

What happened

Reload POM action on a maven project doesn't work.

How to reproduce

1. Add a new dependency on a maven project
2. Reload POM to prime project doesn't work

Did this work correctly in an earlier version?

No / Don't know

Operating System

Linux/Windows

JDK

JDK 17

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

Project is marked with Resolve Project Problems
Project Problems Resolve action prime the project.
But Reload POM is more straightforward

Are you willing to submit a pull request?

No

[neilcsmith-net]

I'm not sure Reload POM is meant to handle that case - you can just clean and build the project from that menu.

cc/ @mbien @sdedic ?

[mbien]

i build projects after adding dependencies which aren't in the local repo yet since it is the most natural way to let maven resolve the dependencies and is a completely IDE independent process.

Reloading a pom will resolve dependencies too, but this is an implementation detail and is done by NetBeans due to other reasons. You might have more luck with NB 19 since it had fixes in that area. But again: reloading a pom shouldn't be the first choice after adding dependencies. RC1 is a bit broken in that area, you would have to wait for RC2 or test a dev build of that PR: https://github.com/apache/netbeans/actions/runs/5600090492 (scroll down)

[albilu]

@mbien Here is the problem:

1. I am writting code and want to use org.json.JSONObject
2. I write the instruction: JSONObject JSONObject = new JSONObject();
3. File is now in error
4. Alt+Enter -> Search Dependencies and Add it to the pom
5. File still in error
6. If run Build the build wil just failed even if it resolve the dependency

A better approch is to be able to quickly run priming to resolve the dependencies. Wich i though Reload POM was there for.
At least it the case in IntelliJ. An then Ctrl+I to import the dependency

[mbien]

I can't reproduce this following the steps.

Also in general: NB doesn't build the project, maven does. So if the build fails after you add a dependency, something is likely wrong with the project. Maybe you have to build the parent project first if the hierarchy is more complicated but build should work if the pom is correct.

[albilu]

No its à simple project. The build failed because there will not be the import org.json.Jsonobject; in the file yet unless you add it manuellement as the library is not in the classpath yet.

You should be able to reproduce this easily. I will maybe record à video to show.

[asbachb]

@albilu can you share an example project?

[albilu]

pomreload.mp4

After adding a new dependency using the quick fix action an immediate build will fail because the file is in error.
Build will only be successful after import statement for org.json.* have been added to the file(with is not automatically possible before the pom reload. unless you know the complete import statement by heart and add it manually)

This is where Reload POM action is useful as it will just prime the project(download the new dependency without failing and annoying the user). This is the case in IntelliJ.
reloadpom.tar.gz

[mbien]

@albilu thanks for the demo. I am not 100% convinced that this is a problem though. Yes the compilation step will fail but before attempting to compile, maven will download all dependencies which aren't there yet. That is also the reason why you can import the class right after you built - since it can be resolved.

what you essentially want is something like:
mvn dependency:go-offline
which will download everything so that subsequent builds can be offline.

or via UI:

The fact that reloading the pom is downloading dependencies is an implementation detail. NetBeans is going to do that in a non-standard way - it is always better to let maven handle the build.

[asbachb]

Actually I don't get the expectation fully: The failing build shown in the demo is caused by the missing import, not because the dependency is not present or the project needs to be reloaded.

From my understanding when you add a dependency it's added to you pom, downloaded automatically (at least with my configuration) and after it's downloaded you're able to add the import.

I guess there's an argument if that added maven dependency also triggers the auto import feature, but not yet sure if this would be a good solution.

[albilu]

From my understanding when you add a dependency it's added to you pom, downloaded automatically (at least with my configuration) and after it's downloaded you're able to add the import.

It weird i did some further cases after your claim and it automatically download indeed in some cases but in other cases it doesn't don't know why.

Anyway it is not really a big deal i think this issue can be closed!
Thanks

[mbien]

cool. btw I am glad to see that someone is actually using the class name search. Since it didn't work for quite some time but got fixed over the last few releases.

NB 19 will also restore some functionality there, e.g #5984