Code conversion error

[edrobal]

Apache NetBeans version

Apache NetBeans 28

What happened

Code conversion truncate code

Language / Project Type / NetBeans Component

java class library

How to reproduce

Initial code is

        ByteArrayOutputStream outStream = new ByteArrayOutputStream();
        int len;

        byte[] buffer = new byte[1024];

        while ((len = input.read(buffer)) != -1) {
            outStream.write(buffer, 0, len);
        }
        input.close();

        return outStream.toByteArray();

Netbeans show convert to try-with-ressources and after code is

        try (input) {
            outStream = new ByteArrayOutputStream();
            int len;
            byte[] buffer = new byte[1024];
            while ((len = input.read(buffer)) != -1) {
                outStream.write(buffer, 0, len);
            }
        }

Did this work correctly in an earlier version?

No / Don't know

Operating System

Linux 6.4.0-150600.23.65-default

JDK

Java: 24.0.2; OpenJDK 64-Bit Server VM 24.0.2+12

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

No

[mbien]

works for me:

    public static void test(InputStream input) throws Exception {
        ByteArrayOutputStream outStream = new ByteArrayOutputStream();
        int len;

        byte[] buffer = new byte[1024];

        while ((len = input.read(buffer)) != -1) {
            outStream.write(buffer, 0, len);
        }
        input.close();
    }

->

    public static void test(InputStream input) throws Exception {
        try (input) {
            ByteArrayOutputStream outStream = new ByteArrayOutputStream();
            int len;
            
            byte[] buffer = new byte[1024];
            
            while ((len = input.read(buffer)) != -1) {
                outStream.write(buffer, 0, len);
            }
        }
    }

[matthiasblaesing]

@mbien the return part is crucial here. The example above should be this:

import java.io.ByteArrayOutputStream;
import java.io.InputStream;

public class Test {

    public static byte[] test(InputStream input) throws Exception {
        ByteArrayOutputStream outStream = new ByteArrayOutputStream();
        int len;

        byte[] buffer = new byte[1024];

        while ((len = input.read(buffer)) != -1) {
            outStream.write(buffer, 0, len);
        }
        input.close();

        return outStream.toByteArray();
    }
}

And the refactoring hint/fix leads to:

import java.io.ByteArrayOutputStream;
import java.io.InputStream;

public class Test {

    public static byte[] test(InputStream input) throws Exception {
        try (input) {
            outStream = new ByteArrayOutputStream();
            int len;
            byte[] buffer = new byte[1024];
            while ((len = input.read(buffer)) != -1) {
                outStream.write(buffer, 0, len);
            }
        }

        return outStream.toByteArray();
    }
}

The hint seems to correctly detect, that the variable outStream must be declared outside the try-with-resource block, but fails to insert the declaration before the block.