Skip to content

Updating to Felix 6.0.1#1063

Merged
asfgit merged 5 commits intoapache:masterfrom
jtulach:Felix601
Jan 2, 2019
Merged

Updating to Felix 6.0.1#1063
asfgit merged 5 commits intoapache:masterfrom
jtulach:Felix601

Conversation

@jtulach
Copy link
Contributor

@jtulach jtulach commented Dec 30, 2018

Updating to Felix 6.0.1 that supports JDK11. CC @pnabbefeld

<specification-version>9.0</specification-version>
</run-dependency>
</dependency>
<dependency>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it I've noticed this dependency on deprecated stuff. Replacing with conditional Class.forName.

Something for @jglick and @sdedic to review.

private static final class SFS extends MultiFileSystem implements LookupListener {

static {
@SuppressWarnings("deprecation") Object _1 = FileSystem$Environment.class; // FELIX-2128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FELIX-2128 nine years ago! AFAICT the intent here was to load some classes which we expected to be loaded anyway. If FileSystem$Environment and FileSystemCapability have been removed from the active codebase then I presume these two class loads could simply be deleted.

FELIX-3477 BTW for the LookupEvent load, apparently. I do not really remember anything about these issues.

@asfgit asfgit merged commit d647a4f into apache:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants