[NETBEANS-1970] Gradle projects are not loading on java 11#1106
Merged
lkishalmi merged 2 commits intoapache:masterfrom Jan 29, 2019
Merged
Conversation
when running on Java 11 or later.
Changing of Gradle User home later.
lkishalmi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well this set of patches makes Gradle project evaluation work on Java 11 even when the Gradle wrapper is below this version, by silently ignore the wrapper specified distribution for loading the project.
Also it contains the refactor of the GradleDistributionManager making it a real class instead of a bunch of utility functions. Now it takes the gradle user home to create one. Though, right now the plugin does not support switching between gradle user home directories, this refactor is one step further to that support.
Removed the automatic install of Gradle from the startup.
Filed leaking private internals through GradleSettings as getVersion() returned a module private NbGradleVersion type.