Skip to content

[NETBEANS-1936] Version splitting Testcode#1248

Closed
gbrinkmann wants to merge 1 commit into
apache:masterfrom
gbrinkmann:patch-2
Closed

[NETBEANS-1936] Version splitting Testcode#1248
gbrinkmann wants to merge 1 commit into
apache:masterfrom
gbrinkmann:patch-2

Conversation

@gbrinkmann
Copy link
Copy Markdown
Contributor

test method testSplitting added

see #1244

test method testSplitting added
@matthiasblaesing
Copy link
Copy Markdown
Contributor

As this is a followup for #1244, this commit should be part of that PR (you can update the PR by cherry picking this commit into the branch, that backs the PR and push it.

@gbrinkmann
Copy link
Copy Markdown
Contributor Author

Thank you.
As this is my first contribution, I've edited these two fragments on github (and should learn better how to work with branches and pull requests).
I cannot cherry pick on github, right?

@matthiasblaesing
Copy link
Copy Markdown
Contributor

You can update PRs by pushing new commits into the branch that was used to create the PR. That even works if you force-push. In your checkout do this:

# switch to patch-1 branch
git checkout patch-1
# cherry-pick the tests into this branch
git cherry-pick 8becb206246d4b01dd18095d50621acb150a3a82
# Run unittests and see if everything works
# Push updated branch - this assumes your first push of patch-1 set the github branch as upstream
git push

On github you will now see two commits in the "Commits" tab. By this time you can close #1248 as the code lives in this PR.

@gbrinkmann
Copy link
Copy Markdown
Contributor Author

gbrinkmann commented May 16, 2019

Thanks a lot for your advice, followed your instructions and had fun learning more how to git and github.
Cherry picked to patch-1, closing.

@gbrinkmann gbrinkmann closed this May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants