Skip to content

Support for Debugging single source java files (JEP-330)#1262

Closed
sarveshkesharwani wants to merge 1 commit intoapache:masterfrom
sarveshkesharwani:singleSourceJavaFileDebug
Closed

Support for Debugging single source java files (JEP-330)#1262
sarveshkesharwani wants to merge 1 commit intoapache:masterfrom
sarveshkesharwani:singleSourceJavaFileDebug

Conversation

@sarveshkesharwani
Copy link
Copy Markdown
Contributor

This feature allows the user to debug any Java File which is not a part of any project.
Although it mentions JEP-330, this feature works fine for JDK versions lower than 11 too.

@geertjanw
Copy link
Copy Markdown
Member

Looks great to me, thanks for this enhancement to your already great support for JEP 330.

@jlahoda
Copy link
Copy Markdown
Contributor

jlahoda commented May 26, 2019

Not sure how exactly is this supposed to work, but I would expect this to work simply as:
-enhance the existing ActionProvider that implements Run, to also start the debugger in the listening mode, and then perform run with the additional parameter that attaches to the debugger. Besides the code to start the debugger, this should only be a few lines of code. Making another copy of JPDAStart is not nice, but opening a random package in a random module is much worse.

Of course, it might be that that the existing ActionProvider is not in a perfect module to touch debugger, but that IMO means it needs a better module, rather than modifying debugger.jpda stashing another ActionProvider into the OpenJDK project.

@junichi11 junichi11 added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label May 29, 2019
@matthiasblaesing
Copy link
Copy Markdown
Contributor

@sarveshkesharwani is this still relevant?

@sarveshkesharwani
Copy link
Copy Markdown
Contributor Author

@matthiasblaesing sorry for the late reply (had a busy month). I do intend to work on this feature soon. However, I think it would be better to start afresh, so, I'll close this PR and create a new one as soon as I'm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) wait-for-feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants