Skip to content

Comments

[NETBEANS-2306] Fix for missing resource AmazonJ2EEServerWizardComponent.containerLabel.text#1282

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
peedeeboy:NETBEANS-2306
Jun 4, 2019
Merged

[NETBEANS-2306] Fix for missing resource AmazonJ2EEServerWizardComponent.containerLabel.text#1282
matthiasblaesing merged 1 commit intoapache:masterfrom
peedeeboy:NETBEANS-2306

Conversation

@peedeeboy
Copy link
Contributor

@peedeeboy peedeeboy commented Jun 4, 2019

What this PR does
Fixes an exception preventing the Server wizard panel being displayed for AWS Elastic Beanstalk servers

Root cause
In the file /enterprise/cloud.amazon/src/org/netbeans/modules/cloud/amazon/ui/serverplugin/Bundle.properties there are the following entries:

AmazonJ2EEServerWizardComponent.envFullURLLabel.text=\ \
AmazonJ2EEServerWizardComponent.containerLabel.text=Container Type:

Having a \ as the last character on the AmazonJ2EEServerWizardComponent.envFullURLLabel.text=\ \ entry causes Java to consider the text on the following line as part of the value of the AmazonJ2EEServerWizardComponent.envFullURLLabel.text property.

Hence the AmazonJ2EEServerWizardComponent.containerLabel.text property can't be found when the Server Wizard tries to render

Files changed

  • /enterprise/cloud.amazon/src/org/netbeans/modules/cloud/amazon/ui/serverplugin/Bundle.properties
    Removed \ \ so the AmazonJ2EEServerWizardComponent.envFullURLLabel.text property will have empty String as it's default value.

Testing

  • Create a new JavaEE Application
  • Choose to add a server. Choose Amazon Beanstalk. Click Next >
    Before this PR:
  • Server Wizard will not be displayed.
  • Checking the Notifications window will reveal the exception 'java.util.MissingResourceException: Can't find resource for bundle org.openide.util.NbBundle$PBundle, key AmazonJ2EEServerWizardComponent.containerLabel.text'
    After this PR:
  • AWS Beanstalk server wizard displayed as expected

@geertjanw
Copy link
Member

Makes sense and thanks for identifying and fixing this problem.

@matthiasblaesing
Copy link
Contributor

Thank you - I agree with Geertjan, the fix makes sense. I had a look at the old code and indeed before the last change the entry was \ \ . There was a trailing space, that was removed.

@matthiasblaesing matthiasblaesing merged commit e8809f2 into apache:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants