[NETBEANS-2306] Fix for missing resource AmazonJ2EEServerWizardComponent.containerLabel.text#1282
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Jun 4, 2019
Merged
Conversation
…ent.containerLabel.text
Member
|
Makes sense and thanks for identifying and fixing this problem. |
Contributor
|
Thank you - I agree with Geertjan, the fix makes sense. I had a look at the old code and indeed before the last change the entry was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes an exception preventing the Server wizard panel being displayed for AWS Elastic Beanstalk servers
Root cause
In the file
/enterprise/cloud.amazon/src/org/netbeans/modules/cloud/amazon/ui/serverplugin/Bundle.propertiesthere are the following entries:Having a \ as the last character on the
AmazonJ2EEServerWizardComponent.envFullURLLabel.text=\ \entry causes Java to consider the text on the following line as part of the value of the AmazonJ2EEServerWizardComponent.envFullURLLabel.text property.Hence the AmazonJ2EEServerWizardComponent.containerLabel.text property can't be found when the Server Wizard tries to render
Files changed
Removed
\ \so the AmazonJ2EEServerWizardComponent.envFullURLLabel.text property will have empty String as it's default value.Testing
Before this PR:
After this PR: