Use Material CSS to make the example look nicer#1552
Merged
neilcsmith-net merged 2 commits intoapache:masterfrom Oct 9, 2019
Merged
Use Material CSS to make the example look nicer#1552neilcsmith-net merged 2 commits intoapache:masterfrom
neilcsmith-net merged 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
FYI: The application generated from the new project template is available here online. |
neilcsmith-net
requested changes
Oct 7, 2019
| <ul id="nav-mobile" class="right hide-on-med-and-down"> | ||
| <li><a target="_blank" href="http://netbeans.org">NetBeans</a></li> | ||
| <li><a target="_blank" href="https://github.com/dukescript/kt-mvvm-demo/tree/FXBeanInfo#readme">JavaFX</a></li> | ||
| <li><a target="_blank" href="https://materializecss.com/">Material CSS</a></li> |
Member
There was a problem hiding this comment.
Shouldn't that say Materialize CSS ? Otherwise happy to merge for 11.2.
neilcsmith-net
added
the
do not merge
neilcsmith-net
approved these changes
Oct 9, 2019
Member
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
Sorry for the noise! Missed that this was opened against release112. Needs to be merged to master. However, realised I can change the base branch myself with this one - last one this applied to I couldn't.
neilcsmith-net
removed
the
do not merge
Akshay-Gupta-19
pushed a commit
to Akshay-Gupta-19/netbeans
that referenced
this pull request
Oct 30, 2019
* Use Material CSS to make the example look nicer * It's Materialize CSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make the Java Frontend Application Gradle project type more attractive, it would be better to make it less HTML-like, and more component like. Using Material CSS is a simple way to do it.
Hopefully @geertjanw finds the new UI more attractive to shoot a video about the excellent support NetBeans provide when it comes to JavaFX light developement. @neilcsmith-net, can we get it into 11.2? It is just a simple HTML change, no code is affected. Thank you.
CCing @lkishalmi