[NETBEANS-3558] Spring Framework 5.2.2#1756
Merged
matthiasblaesing merged 1 commit intoapache:masterfrom Dec 25, 2019
Merged
Conversation
hectorespert
force-pushed
the
spring_framework_5
branch
4 times, most recently
from
78a05e9 to
ee90f35
Compare
hectorespert
force-pushed
the
spring_framework_5
branch
2 times, most recently
from
e0f49af to
69f7340
Compare
matthiasblaesing
requested changes
Dec 25, 2019
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Thank you - looks sane, for the license + notice they can be handled more compact. See inline comment.
| Version: 5.2.2.RELEASE | ||
| Origin: Spring | ||
| License: Apache-2.0-spring5.2.2 | ||
| URL: https://spring.io/projects/spring-framework |
Contributor
There was a problem hiding this comment.
This is a group of dependencies with the same license + notice (my assumption). If so, please use the "Files" header to reference all files the license+notice apply to and remove the additional license + notice files. That way it is better readable.
hectorespert
force-pushed
the
spring_framework_5
branch
from
6bc4fb2 to
f962223
Compare
matthiasblaesing
approved these changes
Dec 25, 2019
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update java/libs.springframework module to add Spring Framework 5.2.2 library dependency for ant projects. NETBEANS-3558