Ensure a clean license stub is used for source config builds #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this changeset the LICENSE file from the root of the repository/source directory was used to create the LICENSE file of the binary build. This worked correctly for the repository because there only the ALv2 is present, but a source config build in the LICENSE file also the references to the license files for the embedded source files with foreign licenses are included. A binary build from a source config thus contains the license info of the source config _and_ the binary build. This is not correct, as the binary config can contains less source only files because they are only required at build time. To fix this, a new license-stub.txt is introduced, that only contains the ALv2 regardless whether it comes from the repository or from a source config build.
BradWalker
approved these changes
Feb 21, 2020
Contributor
|
Hi @matthiasblaesing , I'm in the signing process (on my box it's a bit long) Would be to know if ok for you. |
Contributor
Author
|
@ebarboni both source and binary look sane to me. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this changeset the LICENSE file from the root of the
repository/source directory was used to create the LICENSE file of the
binary build. This worked correctly for the repository because there
only the ALv2 is present, but a source config build in the LICENSE file
also the references to the license files for the embedded source files
with foreign licenses are included.
A binary build from a source config thus contains the license info of
the source config and the binary build. This is not correct, as the
binary config can contains less source only files because they are only
required at build time.
To fix this, a new license-stub.txt is introduced, that only contains
the ALv2 regardless whether it comes from the repository or from a
source config build.