[NETBEANS-4050] - cleanup uses of EMPTY_LIST, EMPTY_SET, EMPTY_MAP #2075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BradWalker
commented
Apr 13, 2020
BradWalker
commented
BradWalker
force-pushed
the
cleanup_EMPTY_LIST
branch
from
73c4826 to
a9124c6
Compare
BradWalker
force-pushed
the
cleanup_EMPTY_LIST
branch
2 times, most recently
from
0c3db71 to
c5b50a5
Compare
Contributor
|
Would be good to have a technical review from other than me. |
Member
|
@ebarboni not reviewing, but all the warning fixes by @BradWalker (which are welcome) have not been merged during freezes. Should be left for review for 12.1 window in my opinion. |
BradWalker
force-pushed
the
cleanup_EMPTY_LIST
branch
2 times, most recently
from
ef6bb2a to
897e3e8
Compare
BradWalker
force-pushed
the
cleanup_EMPTY_LIST
branch
from
897e3e8 to
0840398
Compare
BradWalker
force-pushed
the
cleanup_EMPTY_LIST
branch
from
0840398 to
edbcaf4
Compare
Clean up a bunch of compiler warning messages related to the use of Collections.[EMPTY_LIST, EMPTY_SET, EMPTY_MAP]..
[repeat] /home/bwalker/src/netbeans/java/ant.debugger/src/org/netbeans/modules/ant/debugger/RunTargetsAction.java:145: warning: [unchecked] unchecked conversion
[repeat] allTargets = Collections.EMPTY_SET;
[repeat] ^
[repeat] required: Set<Target>
[repeat] found: Set
BradWalker
force-pushed
the
cleanup_EMPTY_LIST
branch
from
edbcaf4 to
f5f3c9f
Compare
Contributor
|
@BradWalker is this clear to merge? |
Member
Author
Hey @matthiasblaesing, it's ready to go.. I rebased to latest master last night.. |
Contributor
|
Merging - thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.