[NETBEANS-3733] Suggest surefire 2.22.0 for JUnit5 tests.#2144
Merged
sdedic merged 1 commit intoapache:masterfrom May 18, 2020
Merged
[NETBEANS-3733] Suggest surefire 2.22.0 for JUnit5 tests.#2144sdedic merged 1 commit intoapache:masterfrom
sdedic merged 1 commit intoapache:masterfrom
Conversation
jlahoda
reviewed
May 17, 2020
Contributor
jlahoda
left a comment
jlahoda
left a comment
There was a problem hiding this comment.
Overall looks reasonable; not sure about one the logic that sets surefireVersion = SUREFIRE_VERSION_SAFE.
|
|
||
| if (ju5 && !usingSurefire2_22()) { | ||
| surefireVersion = SUREFIRE_VERSION_SAFE_5; | ||
| } else if (usingSurefire28()) { |
Contributor
There was a problem hiding this comment.
Not sure about the logic here - should it be:
Suggested change
| } else if (usingSurefire28()) { | |
| } else if (!usingSurefire28()) { |
sdedic
force-pushed
the
bugfix/NETBEANS-3733_surefire-junit5
branch
from
0ef7a6b to
78778ee
Compare
Contributor
|
Probably too late for 12.0, so lets put a milestone of 12.1 on it so its not missed later on |
Member
|
@mcdonnell-john not sure, it's certainly an annoyance. There's a chance we're going to need one more beta, so putting 12.0 on it and leaving it to @ebarboni to make the call. |
Member
|
OTOH, @sdedic seems to have gone for it anyway! |
Member
Author
|
OOPS! Feel free to rollback :-/ |
Member
|
@sdedic 😆 well Eric really will need to review it now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvement to 073c42c: the IDE properly tests for JUnit5 in
runSingleMethodEnabled, so it triggers a suggest/status line message if the project is not properly set up. But the display message and POM fix installs JUnit4+older surefire, which does not work in JUnit5 environment.I've just improved the messages for JUnit5 case + used proper Surefire version.