Do not blindly cast to IndexedClassDecl while reassigning anonymous c…#2170
Merged
jlahoda merged 1 commit intoapache:masterfrom Jun 14, 2020
Merged
Conversation
…lass numbers, as the class decl may not be IndexedClassDecl.
jlahoda
added
the
Java
|
+1 Approved, Thanks for doing this Jan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lass numbers, as the class decl may not be IndexedClassDecl.
While running on current JDK 15 without nb-javac, the parser produces ordinary JCClassDecl, not IndexedClassDecl, and then the casts to IndexedClassDecl fail, and various tests (like code completion tests) fail due to this.
Eventually, we probably want to get rid of IndexedClassDecls altogether, but more testing will be needed for that.
Added also a related test to partial reparse test, to verify things work reasonably during partial reparse.