[NETBEANS-4499] Fixed unit tests for Symfony 2/3 #2214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junichi11
approved these changes
Jun 24, 2020
tmysik
reviewed
Jun 25, 2020
...2/test/unit/src/org/netbeans/modules/php/symfony2/commands/SymfonyCommandsXmlParserTest.java
Show resolved
Hide resolved
Member
I am missing an explanation. Why is it done, please? |
Contributor
Author
|
@tmysik File for This is related bug: https://bz.apache.org/netbeans/show_bug.cgi?id=252901 |
Member
|
I can see it is very old issue so I guess if we can parse Symfony XML without errors now, we are OK. Thanks! |
tmysik
approved these changes
Jun 25, 2020
Member
|
@junichi11 Please merge it if it can be done now :) Thanks. |
Member
|
Let's merge it after conflicting files are fixed. Thanks! |
Contributor
Author
|
@junichi11 Merge conflicts are solved. |
Member
|
@KacerCZ Could you rebase and squash if possible? |
KacerCZ
force-pushed
the
netbeans-4499-fix-symfony2-tests
branch
from
0356615 to
e5cb437
Compare
https://issues.apache.org/jira/browse/NETBEANS-4499 - Created file `issue232490.xml` from `symfony2-commands.xml` - Commented test SymfonyCommandsXmlParserTest:testIssue252901 - Enabled tests in Travis and Github Actions.
KacerCZ
force-pushed
the
netbeans-4499-fix-symfony2-tests
branch
from
e5cb437 to
aed21a4
Compare
Contributor
Author
|
@junichi11 I tried, hopefuly it is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/NETBEANS-4499
issue232490.xmlfromsymfony2-commands.xml