[NETBEANS-4308] Deadlock in SQLEditorSupport #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the synchronization in SQLEditorSupport#closeLogger. The critical part (ensuring logger is not closed while it could be acquired) is protected by the finer grained loggerLock and thus the monitor on SQLEditorSupport is not needed. The deadlock sequence showed: - the EDT held the monitor of SQLEditorSupport - a task was dispatched into a request processor - the EDT waited for the task to finish - the task tried to enter the monitor of SQLEditorSupport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the synchronization in SQLEditorSupport#closeLogger. The critical
part (ensuring logger is not closed while it could be acquired) is
protected by the finer grained loggerLock and thus the monitor on
SQLEditorSupport is not needed.
The deadlock sequence showed: