Skip to content

NETBEANS-4533 : Netbeans 4533 chinese char problem table header #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lkishalmi merged 2 commits into from
Oct 10, 2020
Merged

NETBEANS-4533 : Netbeans 4533 chinese char problem table header #2435

lkishalmi merged 2 commits into from
Oct 10, 2020

Conversation

@adrienDG
Copy link
Contributor

@adrienDG adrienDG commented Oct 9, 2020

No description provided.

@lkishalmi lkishalmi modified the milestones: 12.3, 12.2 Oct 10, 2020
@lkishalmi
Copy link
Contributor

lkishalmi commented Oct 10, 2020

Just some info from the issue here:
Please note that this is a duplicate of a bug already logged in the old Bugzilla : https://bz.apache.org/netbeans/show_bug.cgi?id=270091

@lkishalmi
Copy link
Contributor

lkishalmi commented Oct 10, 2020

Checked the email address, it seems to be correctly provided. I'm going to merge this.
Thank you for your contribution!

@lkishalmi lkishalmi merged commit 7990cee into apache:master Oct 10, 2020
lkishalmi added a commit that referenced this pull request Oct 10, 2020
@lkishalmi
Revert "NETBEANS-4533 : Netbeans 4533 chinese char problem table head…
f0d224d 
…er (#2435)"

This reverts commit 7990cee.
@lkishalmi
Copy link
Contributor

lkishalmi commented Oct 10, 2020

@adrienDG could you make your email public on github? Squash and merge produces: 72509841+adrienDG@users.noreply.github.com email address in the repository.

@adrienDG adrienDG deleted the NETBEANS-4533-chinese-char-problem-table-header branch October 12, 2020 07:54
@adrienDG
Copy link
Contributor Author

adrienDG commented Oct 12, 2020 •
edited
Loading

@adrienDG could you make your email public on github? Squash and merge produces: 72509841+adrienDG@users.noreply.github.com email address in the repository.

I changed my settings, it is now public.
Are we not supposed to close the related issue @lkishalmi ? Do you know in which release it will be available?
Thanks!

@lkishalmi lkishalmi removed this from the 12.2 milestone Oct 12, 2020
@lkishalmi
Copy link
Contributor

lkishalmi commented Oct 12, 2020

I need to revert this change. You need to file a new PR. I'm sorry for the inconveniences.

@lkishalmi lkishalmi mentioned this pull request Oct 12, 2020
Merged
lkishalmi added a commit that referenced this pull request Oct 12, 2020
@lkishalmi
Revert "NETBEANS-4533 : Netbeans 4533 chinese char problem table head…
e7d97e8 
…er (#2435)"

This reverts commit 7990cee.
@adrienDG
Copy link
Contributor Author

adrienDG commented Oct 13, 2020

I'll create a new PR. Can I know what is the problem with the merge please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adrienDG @lkishalmi