Annotation processors may generate class files: #2468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-that have a name different from any source file in the source roots -even while running in the editor But neither of these seems to be working - fixing.
jlahoda
added
the
Java
jlahoda
commented
Oct 18, 2020
| if (activeRoot == null) { | ||
| activeRoot = getClassFolderForApt(l, sibling, baseName); | ||
| } | ||
| if (activeRoot == null && siblings.hasSibling()) { |
Contributor
Author
There was a problem hiding this comment.
This is the meat of the fix - the above attempts to compute the target class folder might have failed, because, if sibling is null, it will try to find the original source root based on "baseName" - but if the newly generated classfile's name does not correspond to any source file (which is valid, of course), this search fails. So adding a new layer, using the "siblings" utility.
JaroslavTulach
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-that have a name different from any source file in the source roots
-even while running in the editor
But neither of these seems to be working - fixing.