Fixing a mistake in ergonomics project detection, so that it can detect OpenJDK projects.#2720
Merged
neilcsmith-net merged 1 commit intoapache:deliveryfrom Feb 3, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
JaroslavTulach
approved these changes
Feb 1, 2021
JaroslavTulach
left a comment
JaroslavTulach
left a comment
There was a problem hiding this comment.
Integrating together with a unit test would be great.
Member
|
Thanks for test, but can you squash the commits and force push for merging? |
…ct OpenJDK projects.
jlahoda
force-pushed
the
fod-openjdk-project
branch
from
83d72bc to
b307259
Compare
geertjanw
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, if the project marker file relative path contains
../, we attempt to use the parent file. But, the../is never stripped from the marker file relative path. Trying to fix here.