[NETBEANS-5326] LSP codelens output fixes#2725
Conversation
JaroslavTulach
left a comment
There was a problem hiding this comment.
Sharing the Run and Debug and single and all execution is certainly good idea.
|
At the moment, we don't have another beta scheduled, although discussions elsewhere might lead to one. If not, I don't feel in a position to assess this one against the bug priority guidelines. Can we get assessment of the necessity to get this in to 12.3? Thanks! |
|
@neilcsmith-net I've updated the description and created NETBEANS-5326 based on our internal report. That should allow to asses the importance for 12.3. I consider the fix to be of a very low risk, especially comparing to the currently broken behavior. |
|
@entlicher thanks. It's more about criticals and blockers generally requiring another beta for testing. Quite happy for major (or minors) to come in then where available, particularly when they're low risk! @geertjanw and I put forward an optimistic schedule with only two betas initially due to late start on the release (no RM in place). At least one more beta is looking likely now anyway. I've updated the title - hopefully Apache infra will link the two. |
| CompletableFuture.runAsync(() -> { | ||
| try { | ||
| waitForDebuggeeConsole.get(5, TimeUnit.SECONDS); | ||
| waitForDebuggeeConsole.get(1, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Hi, incidentally I attempted to solve this delay by removing it :) completely in #2754 . See the discussion in that PR.
|
Merged per Neil's advice in #2754 |
This is a fix of NETBEANS-5326
If Run test/Debug test code lenses are used through LSP protocol, the actual test output is not visible. In case of Debug tes, the output is visible when it succeeds, however, it is significantly cut when it fails, preventing from seeing the test failure.
Correction of output from Run/Debug code lens actions.