[NETBEANS-5499] Upgrade Felix library, works on JDK16.

[sdedic]

I have tried Felix 7.0.0 with a minimal application and it seems that URL handling is fixed.

[sdedic]

Recommitted with the necessary project.{xml,properties} changes. Sorry for the inconvenience.

[JaroslavTulach]

Test org.netbeans.core.netigso.EnabledAutoloadTest FAILED

[JaroslavTulach]

Once the tests pass, feel free to integrate.

[sdedic]

Had to upgrade OSGi as well, Felix 7.0 seems to require OSGI 8 core. osgi-cmp remains at 7.0 (Compendium 8.0 spec is still draft) while osgi-core 8.0 was released in December 2020.

Please re-review.

[JaroslavTulach]

Would having a test failing on JDK16 before and succeeding with this change be beneficial?

[sdedic]

Would having a test failing on JDK16 before and succeeding with this change be beneficial?

Can you suggest how to proceed with such test implementation ? i.e. two variants of the Felix (OSGi ?) library wrapper modules - how ? Or some simpler way ?

[JaroslavTulach]

Can you suggest how to proceed with such test implementation ? ... Or some simpler way ?

The problems only appears on JDK16, right? We should have JDK16 gate running commit validation and failing with some older commit like 5a9c949 - then apply this PR and the gate starts passing. Simple.

[geertjanw]

Is this ready to merge, for 12.4 inclusion, please do so if so @JaroslavTulach @sdedic.

[sdedic]

@jtulach I have modified a commit-validation test to parse an URL - which (on my machine) fails on JDK16 without the felix change. But I failed to enable commit-validation testsuite on JDK16. At least locally, I need a ton of --add-opens (copied from etc/netbeans.conf) and even then a consistency test fails:

Some files do not provide valid menu elements[ File MultiFileObject@115e5315[Toolbars/Memory/org-netbeans-modules-timers-OpenTimeComponentAction.shadow] does not provide correct instance: java.lang.Object@739d42c5 url: nbfs://nbhost/SystemFileSystem/Toolbars/Memory/org-netbeans-modules-timers-OpenTimeComponentAction.shadow]

[sdedic]

@geertjanw there was a real travis failure before the last push (that's why I recommitted the changes). Please let the builds for PRs to finish / settle ... I hope the master won't be broken :)

[geertjanw]

OK. Delivery branch exists. Please say when you're happy and will then continue the process.