Skip to content

Conversation

@JaroslavTulach
Copy link

@JaroslavTulach JaroslavTulach commented Apr 14, 2021

There are frequent user reports of upgrading to new (development) version and nothing being working then.

Why that happens? One hypothesis suggests the problem is in sharing the same userdir between different versions. This PR avoids that by isolating the userdirs between different versions, by including the .vsix own version in the name of the userdir.

@JaroslavTulach JaroslavTulach added this to the 12.4 milestone Apr 14, 2021
@JaroslavTulach JaroslavTulach self-assigned this Apr 14, 2021
@sdedic
Copy link
Member

sdedic commented Apr 15, 2021

This can IMHO have some unexpected consequences, i.e. our famous issues with Gradle project trust: as soon as the user upgrades ASF NBJLS extension, his/her approvals will be gone. Now that particular question does not appear that often, but still...
I can see considerable benefit when switching either from a stable TO a development version or maybe between development versions, less when switching between released versions. It's also perfectly OK for the cachedir.

Could there be at least an (optional) setting where the user (config) dir is, so it could be possibly overriden ?

@JaroslavTulach
Copy link
Author

considerable benefit when switching either from a stable TO a development version or maybe between development versions, less when switching between released versions

Right. This feature is (hopefully) only needed for the development builds - at least the reports we have so far concern only dev builds. The question is: how to identify dev vs. release build?

@MartinBalin
Copy link
Contributor

Separating dev and release in VSCode can be hard. userdir is named just by extension inside Code/user/globalStorage. And naming the VSIX like asf.apache-netbeans-java-dev will be counterproductive as you will always have to uninstall release version when trying dev. ...

@geertjanw
Copy link
Member

Should this be merged, please go ahead, if so, @JaroslavTulach @sdedic.

@JaroslavTulach JaroslavTulach modified the milestones: 12.4, 12.5 Apr 16, 2021
@ebarboni
Copy link
Contributor

@JaroslavTulach can we merge this or should it be postponed?

@JaroslavTulach
Copy link
Author

There doesn't seem to be an agreement, that this is the right fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants