[NETBEANS-5587] Support SNAPSHOT versions of dependencies. #2895
Conversation
| * Checks GAV split with -SNAPSHOT and a maven-like timestamp/sequence as the | ||
| * snapshot unique id. | ||
| */ | ||
| public void testGavSplitFixedSnapshotWithMavenTimestamp() throws Exception { |
There was a problem hiding this comment.
Good! Btw. I think I had similar problem in Maven. When a really large project (bck2brwsr in my case) was just partially rebuilt, it started to download these dated artifacts from snapshot repository. Then classpath was full of dated artifacts and Bck2Brwsr had problems with it (as it takes JARs from classpath and generates .js files along them) - the names of JARs were suddenly different to what one normally expected.
|
@lkishalmi does the change looks sane ? Please review/comment. |
lkishalmi
left a comment
lkishalmi
left a comment
There was a problem hiding this comment.
Nice one!
Being out of the Maven world it is really easy to forget that the bad practice of SNAPSHOT versions are still a thing there...
|
@lkishalmi would you support including this one into |
|
Sure. The change itself is "trivial" enough and it has tests as well. |
4 participants
I have changed the
gavsplit, since versions provided in the artifact ID contain 4th component, the{timestamp}-{sequenceno}for Mavenrepo SNAPSHOT artifacts.I changed the code to search from the start, as the 'official' syntax for artifact ID is
group:artifact:version[:classifier][@ext] ... so looking for 3rd:delimiter seems to satisfy both this andgroup:artifact:version:timestamp-sequencewhich comes togavSplitfor Maven SNAPSHOTs.