Skip to content

Conversation

@mbien
Copy link
Member

@mbien mbien commented Jun 16, 2021

small change which attempts to make netbeans.conf a bit easier to read and edit.

motivation:
the long list of module options is fairly uninteresting from the users point of view. The most likely usecase for editing netbeans.conf is to change the path to the JDK or to edit some JVM settings. This change extracts the module options and formats the remaining JVM flags so that they are easier to read and edit.

@neilcsmith-net
Copy link
Member

Does this work with the Windows launcher?!

@mbien
Copy link
Member Author

mbien commented Jun 17, 2021

Does this work with the Windows launcher?!

I just tested it and it doesn't seem to like the variable substitution. What is used to parse the conf file on windows?

@neilcsmith-net
Copy link
Member

Yes, I thought it might be problematic. It's here I think - https://github.com/apache/netbeans/blob/master/nb/ide.launcher/windows/nblauncher.cpp#L461 and possibly replicated in the platform launcher.

@mbien
Copy link
Member Author

mbien commented Jun 17, 2021

Yes, I thought it might be problematic. It's here I think - https://github.com/apache/netbeans/blob/master/nb/ide.launcher/windows/nblauncher.cpp#L461 and possibly replicated in the platform launcher.

thanks for the pointers! i am going to take a look if there is a way to make all launchers happy. I am going to try to avoid having to build netbeans on windows since I have nothing set up there.

@mbien
Copy link
Member Author

mbien commented Jun 17, 2021

the win launcher does not support any kind of variables, its only looking for hardcoded property names. I am going to close this.

@mbien mbien closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants