Merged
Conversation
matthiasblaesing
approved these changes
Jan 6, 2022
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks ok to me, the only question I have is regarding the removed tests: Might it make sense to comment them out to restore them if a model implemention is later added? This question is without any bias, as I really no idea how the CND cluster works.
Contributor
Author
|
Who knows, maybe somebody adds a model impl later on. Let's restore those tests, commented out, and let's move on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds more passing tests to the cnd cluster (cnd.remote, cnd, cnd.toolchain)
cnd.remote depended on "cnd.model.api", which we have not integrated in Apache NetBeans (to be replaced with LSP). Tests that required validating the model
are modified accordingly dropping this dependency.
After this the cnd cluster should test properly (dlight cluster requires some extra care, though).