Create JavaParser dumpfile on FINE log level only.

[lkishalmi]

This is a trivial PR addressing the issue on #3728. Which puts the dumpfile creation under FINE loglevel.

[matthiasblaesing]

The change in VanillaPartialReparser is unnessary, as the code path can only be hit if assertions are enabled (with assertions disabled (i.e. a non dev build), 332 is not hit and a stays false):

netbeans/java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

Lines 331 to 333 in 22368c4

	boolean a = false;
	assert a = true;
	if (a && LOGGER.isLoggable(Level.FINE)) {

IMHO then it is correct, that the problem is reported.

I don't think these changes address the problem reported. The reported dump files are created by VerifyPartialReparse:

netbeans/java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

Lines 512 to 558 in 22368c4

	private void verifyCompilationInfos(CompilationInfoImpl reparsed, CompilationInfoImpl verifyInfo) throws IOException {
	if (cancel.get()) return ;
	String failInfo = "";
	//move to phase, and verify
	if (verifyInfo.toPhase(reparsed.getPhase()) != reparsed.getPhase()) {
	failInfo += "Expected phase: " + reparsed.getPhase() + ", actual phase: " + verifyInfo.getPhase();
	}
	if (cancel.get()) return ;
	//verify diagnostics:
	Set<String> reparsedDiags = (Set<String>) reparsed.getDiagnostics().stream().map(this::diagnosticToString).collect(Collectors.toSet());
	if (cancel.get()) return ;
	Set<String> verifyDiags = (Set<String>) verifyInfo.getDiagnostics().stream().map(this::diagnosticToString).collect(Collectors.toSet());
	if (cancel.get()) return ;
	if (!Objects.equals(reparsedDiags, verifyDiags)) {
	failInfo += "Expected diags: " + reparsedDiags + ", actual diags: " + verifyDiags;
	}
	if (cancel.get()) return ;
	String reparsedTree = treeToString(reparsed, reparsed.getCompilationUnit());
	if (cancel.get()) return ;
	String verifyTree = treeToString(verifyInfo, verifyInfo.getCompilationUnit());
	if (cancel.get()) return ;
	if (!Objects.equals(reparsedTree, verifyTree)) {
	failInfo += "Expected tree: " + reparsedTree + "\n" + " actual tree: " + verifyTree;
	}
	if (!failInfo.isEmpty() && !cancel.get()) {
	Utilities.revalidate(reparsed.getFileObject());
	File dumpFile = JavacParser.createDumpFile(reparsed);
	if (dumpFile != null) {
	try (OutputStream os = new FileOutputStream(dumpFile);
	PrintWriter writer = new PrintWriter(new OutputStreamWriter(os, StandardCharsets.UTF_8))) { //NOI18N
	writer.println("Incorrectly reparsed file: " + reparsed.getFileObject().toURI());
	Snapshot original = reparsed.getPartialReparseLastGoodSnapshot();
	if (original != null) {
	writer.println("----- Original text: ---------------------------------------------");
	writer.println(original.getText());
	};
	writer.println("----- Updated text: ---------------------------------------------");
	writer.println(reparsed.getSnapshot().getText());
	writer.println("----- Errors: ---------------------------------------------");
	writer.println(failInfo);
	}
	}
	LOGGER.log(Level.INFO, "Incorrect partial reparse detected, dump filed: " + dumpFile);
	} else {
	reparsed.setPartialReparseLastGoodSnapshot(reparsed.getSnapshot());
	}
	}

line 534 creates the diff between the trees. As dumping is already partially protected it might be an option to tie the activation of VerifyPartialReparse to assertions:

netbeans/java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

Lines 606 to 614 in 22368c4

	@MimeRegistration(service=TaskFactory.class, mimeType="text/x-java")
	public static final class FactoryImpl extends TaskFactory {
	@Override
	public Collection<? extends SchedulerTask> create(Snapshot snapshot) {
	return Collections.singletonList(new VerifyPartialReparse());
	}
	}

 @MimeRegistration(service=TaskFactory.class, mimeType="text/x-java") 
 public static final class FactoryImpl extends TaskFactory { 
  
     @Override 
     public Collection<? extends SchedulerTask> create(Snapshot snapshot) { 
         boolean  enableVerifier = false; 
         assert enableVerifier = true; 
         if (enableVerifier) { 
             return Collections.singletonList(new VerifyPartialReparse()); 
         }
     } 
  
 } 

@jlahoda what do you think about this?

[jlahoda]

Ok, more or less as a stop gap measure.

[lkishalmi]

Closing in favor of #3850