Closed
Conversation
This reduces the use of reflection in the VM. This has the net effect of making the application more efficient.
mbien
requested changes
Aug 26, 2022
| assertEquals(props, desc.getProps()); | ||
|
|
||
| String[] correctArgs = args.clone(); | ||
| String[] correctArgs = new ArrayList<String>.toArray(args); |
Member
There was a problem hiding this comment.
this doesn't compile since the () is missing. But what worse is that this is wrong. It would create an empty AL and copy null into the first element of args to mark the end of the (empty) array.
please use Arrays.copyOf(args, args.length) for example. Same applies to the other occurrences.
Member
Author
|
This is not well thought about it.. It's problematic on several fronts. Therefore, abandon it and come back later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove usage of clone() when a copy constructor will work.
This reduces the use of reflection in the VM. This has the net effect of making
the application more efficient.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.