add gradle JDK compatibility notice to readme build section. #5913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Gradle
mbien
force-pushed
the
update-readme_delivery
branch
from
7f27754 to
6a58e34
Compare
neilcsmith-net
approved these changes
May 3, 2023
Member
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
Looks good to me. In some ways would be good to be more specific, but we'll probably just forget to keep it up-to-date! 😄
After NB18 we could probably look at rethinking the README a bit more, or even using a different README for source releases.
Member
Author
|
this whole thing feels like such an unnecessary restriction. Wondering if it would be difficult to revert the module back to ant. also ideally the build itself should print a useful message on failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5836
the gradle daemon is a bit of a mystery to me. I tried -D, env vars etc, the only way to make this work was to put it into the gradle.properties (that is also how we set up CI). The most confusing aspect: once it works, you can remove the properties again and it will keep working until you remove the whole
.gradlefolder. (yes I did kill the daemon manually between retries)