No need to show Apache license on first startup#683
Merged
geertjanw merged 1 commit intoapache:masterfrom Aug 15, 2018
Merged
Conversation
Member
|
Agreed, and thanks, that will make the startup smoother. |
Contributor
|
Just one question: Does this have consequences for Platform applications? Could they have used the facility to show their "own" license? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For historical reasons we require all users to accept license of the IDE on first startup. The license has been updated to Apache one for 9.0 release. However I believe there is no need to show this license dialog/warning at all.
Removing it. Emptying the Java class (but keeping it around), removing reference in Unix launcher, as well as Windows one (but without rebuilding the binary). The license warning dialog is gone on all systems, once Windows launchers are rebuilt, the Java class
AcceptLicensecan be deleted as well.