Skip to content

[NETBEANS-1074] Module Review javascript2.nodejs#729

Merged
sdedic merged 1 commit intoapache:masterfrom
sdedic:netbeans-1074-2nd-review-javascript2-nodejs
Aug 21, 2018
Merged

[NETBEANS-1074] Module Review javascript2.nodejs#729
sdedic merged 1 commit intoapache:masterfrom
sdedic:netbeans-1074-2nd-review-javascript2-nodejs

Conversation

@sdedic
Copy link
Member

@sdedic sdedic commented Aug 20, 2018

Added a few missing licenses, replaced default license stubs in test data with Apache2 license.

@sdedic sdedic changed the title [NETBEANS-1074] Review Module javascript2.nodejs [NETBEANS-1074] Module Review javascript2.nodejs Aug 20, 2018
@sdedic sdedic merged commit afe53fc into apache:master Aug 21, 2018
@matthiasblaesing
Copy link
Contributor

@sdedic could you please also have a look at the license file for nodejs?:

https://github.com/sdedic/incubator-netbeans/blob/53f7d2cab07b791aa92f404be729fb0a2312fb3b/javascript2.nodejs/external/nodejs-license.txt

The file is currenty "unconventional".

@junichi11
Copy link
Member

I overlooked it when I reviewed, sorry.

Results of ant -Dcluster.config=full verify-libs-and-licenses:

javascript2.nodejs/external/nodejs-license.txt has a non-header line in the header block: "Copyright Node.js contributors. All rights reserved."
javascript2.nodejs/external/nodejs-license.txt has no Files header and no corresponding nodejs.jar or nodejs.zip could be found
javascript2.nodejs/external/javascript2.nodejs-nodejs-resources.zip is not associated with any license file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants