[NETBEANS-1161] Move java modules to java subdirectory#745
Merged
geertjanw merged 6 commits intoapache:masterfrom Aug 22, 2018
ralphbenjamin:NETBEANS-1161_move_java_modules_to_java_subdirectory
Merged
[NETBEANS-1161] Move java modules to java subdirectory#745geertjanw merged 6 commits intoapache:masterfrom ralphbenjamin:NETBEANS-1161_move_java_modules_to_java_subdirectory
geertjanw merged 6 commits intoapache:masterfrom
ralphbenjamin:NETBEANS-1161_move_java_modules_to_java_subdirectory
Conversation
Member
|
Wow, that's fast work. :-) Thanks @ralphbenjamin. (Feel free to take on the ide cluster next.) |
Contributor
Author
|
Thanks @geertjanw! But before I pickup anything else, it seems from the build I'm not done yet with the java cluster :-) |
Contributor
|
This might be what's wrong with my 2 prs will take a look tonight |
Member
|
If this results in the build succeeding, should we merge this pr, or is there more to be done here? |
Member
|
OK, everything is green, great job, any reason not to merge this? |
Contributor
Author
|
@geertjanw I think someone should review the commits before merging. |
Member
|
What specifically would you like to be reviewed, which parts are you most unsure about? |
Member
|
Awesome, merging this. |
ralphbenjamin
deleted the
NETBEANS-1161_move_java_modules_to_java_subdirectory
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.