binaries-list dependency checker needs to set up the env for maven #7674
Conversation
mbien
added
CI
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
I wished I could run workflows locally.
You should be able to run them on your own repo branch though.
yeah true, I have also a dummy PR for similar reasons here mbien#1. It still is not quite the same that I have to push first. I could have done it in this case I believe if i would have pushed this PR branch to mbien/master, then trigger it manually via actions. I have to give this a try one day https://github.com/nektos/act |
|
works. thanks for reviewing! btw I obviously did test this locally first, just in a slightly different environment |
It doesn't have to be in master. You can choose the PR branch in the trigger UI. Although possibly this should also run on push to itself like the native workflows do anyway? |
|
the reason I wrote this was to discover dependencies which would need updates. For this I typically run it locally. I don't quite see the value of triggering it automatically during PRs which modify binaries-list files - since at this point the dev already figured out what to update. You can see on the history that i run this once a month or so. Nobody else ran it so far. It could be run automatically weekly or something like that. But will anyone look at this? |
|
I didn't mean running it when any PRs are opened - I just mean adding something like https://github.com/apache/netbeans/blob/master/.github/workflows/native-binary-build-launcher.yml#L38 so it runs every time you push a change to the workflow in your personal repo. |
oh, thats a cool trick! Going to add this next time I update it. |
|
Believe me, if that wasn't in those I'd still be writing the PRs to get them in! 😄 |
2 participants
overlooked something for #7644. I wished I could run workflows locally.