Skip to content

[NETBEANS-1074] Module Review libs.amazon#785

Merged
matthiasblaesing merged 1 commit intoapache:masterfrom
arusinha-zz:module-review-libs.amazon
Aug 28, 2018
Merged

[NETBEANS-1074] Module Review libs.amazon#785
matthiasblaesing merged 1 commit intoapache:masterfrom
arusinha-zz:module-review-libs.amazon

Conversation

@arusinha-zz
Copy link

Added maven coordinates for externals jar
Had corrected corresponding license files

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - the same comment as in #786 applies here two: at least the ASF components have a notice file, but the aws sdk should also be checked.

@arusinha-zz arusinha-zz force-pushed the module-review-libs.amazon branch from 481ae31 to 8aa1749 Compare August 27, 2018 10:11
@arusinha-zz
Copy link
Author

Added the notice file for following ext jars
aws-java-sdk-1.2.1.jar
commons-logging-1.1.1.jar
commons-codec-1.3.jar
httpclient-4.1.1.jar
httpcore-4.1.jar

for aws-java-sdk notice was copies from below link
https://github.com/aws/aws-sdk-java/blob/master/NOTICE.txt

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good. I left one comment inline. Thank you.

// Version 2.0, in this case for Commons Logging
// ------------------------------------------------------------------

Commons Logging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the useless comment in lines 1-5 (I realise, that the original file most probably holds the same text). We should carry the notice, but we also should analyse it for relevant parts and the comment is useless.

@arusinha-zz arusinha-zz force-pushed the module-review-libs.amazon branch from 8aa1749 to f45cce4 Compare August 28, 2018 09:21
@arusinha-zz
Copy link
Author

Had corrected commons-logging-1.1.1-notice.txt file

@matthiasblaesing matthiasblaesing merged commit 208af3c into apache:master Aug 28, 2018
@arusinha-zz arusinha-zz deleted the module-review-libs.amazon branch March 1, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants