[NETBEANS-1074] Module Review libs.amazon#785
Conversation
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks good - the same comment as in #786 applies here two: at least the ASF components have a notice file, but the aws sdk should also be checked.
481ae31 to
8aa1749
Compare
|
Added the notice file for following ext jars for aws-java-sdk notice was copies from below link |
matthiasblaesing
left a comment
There was a problem hiding this comment.
In general this looks good. I left one comment inline. Thank you.
| // Version 2.0, in this case for Commons Logging | ||
| // ------------------------------------------------------------------ | ||
|
|
||
| Commons Logging |
There was a problem hiding this comment.
Please remove the useless comment in lines 1-5 (I realise, that the original file most probably holds the same text). We should carry the notice, but we also should analyse it for relevant parts and the comment is useless.
8aa1749 to
f45cce4
Compare
|
Had corrected commons-logging-1.1.1-notice.txt file |
Added maven coordinates for externals jar
Had corrected corresponding license files