Issue #271110 - Attempt to pass -DarchetypeRepository to 3.x maven-archetype-plugin#788
Conversation
|
Not much happened in the months prior to the initial code donation, so not much could have been lost. |
|
I think that @tstupka should create a PR if possible because he is the author of the code. |
|
Ah, sorry, it's your patch. |
matthiasblaesing
left a comment
There was a problem hiding this comment.
The change was already accepted and looks sane, so feel free to merge.
For the "what happend to commits after donation comment": I contacted all people listed as committers in mercurial, that created commits after the donation. I asked them to reapply the patched on the apache repository. It was CCed to the private list to keep the PMC up-to-date:
https://lists.apache.org/thread.html/56ab329e71ad9955138edf6399625f2d627ac315b72bcb91c8fd7fb5@%3Cprivate.netbeans.apache.org%3E
|
Thanks, merging. |
BTW in this case I was not listed even as the author, since the patch was applied without the right |
The fix of BZ #271110 was pushed to Mercurial by @tstupka a couple months before the initial code donation, but apparently was never ported to Git. I am very disturbed that at least two months’ worth of commit history seems to have been discarded. What else was lost?