Skip to content

Issue #271110 - Attempt to pass -DarchetypeRepository to 3.x maven-archetype-plugin#788

Merged
geertjanw merged 1 commit intoapache:masterfrom
jglick:archetypeRepository-271110
Aug 25, 2018
Merged

Issue #271110 - Attempt to pass -DarchetypeRepository to 3.x maven-archetype-plugin#788
geertjanw merged 1 commit intoapache:masterfrom
jglick:archetypeRepository-271110

Conversation

@jglick
Copy link
Contributor

@jglick jglick commented Aug 24, 2018

The fix of BZ #271110 was pushed to Mercurial by @tstupka a couple months before the initial code donation, but apparently was never ported to Git. I am very disturbed that at least two months’ worth of commit history seems to have been discarded. What else was lost?

@geertjanw
Copy link
Member

Not much happened in the months prior to the initial code donation, so not much could have been lost.

@junichi11
Copy link
Member

I think that @tstupka should create a PR if possible because he is the author of the code.

@junichi11
Copy link
Member

Ah, sorry, it's your patch.

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change was already accepted and looks sane, so feel free to merge.

For the "what happend to commits after donation comment": I contacted all people listed as committers in mercurial, that created commits after the donation. I asked them to reapply the patched on the apache repository. It was CCed to the private list to keep the PMC up-to-date:
https://lists.apache.org/thread.html/56ab329e71ad9955138edf6399625f2d627ac315b72bcb91c8fd7fb5@%3Cprivate.netbeans.apache.org%3E

@geertjanw
Copy link
Member

Thanks, merging.

@geertjanw geertjanw merged commit d1c61e6 into apache:master Aug 25, 2018
@jglick
Copy link
Contributor Author

jglick commented Aug 27, 2018

all people listed as committers in mercurial, that created commits after the donation

BTW in this case I was not listed even as the author, since the patch was applied without the right hg command.

@jglick jglick deleted the archetypeRepository-271110 branch August 27, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants