[NETBEANS-1074] Module Review libs.elimpl#825
Conversation
junichi11
commented
Aug 31, 2018
junichi11
commented
- Add the license header to binaries-list and README
- Fix the license.txt file
- el-impl-2.2.99.jar is a patched jar file
| @@ -0,0 +1,387 @@ | |||
| Name: Expression Language Implementation | |||
| Description: Provides an implementation of the Expression Language (EL). | |||
| Version: 2.2.99 (Implementation version: 3.0-b07) | |||
There was a problem hiding this comment.
Should we remove (Implementation version: 3.0-b07)? or use it?
There was a problem hiding this comment.
This fails verification, as the version string is expected verbatim in the filename. As the name refers to the implementation version, I would just use that.
There was a problem hiding this comment.
I'll fix to Version: 3.0-b07. Thanks!
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| The EL impl library in external/el-impl.jar is patched with file from the 'https://netbeans.org/bugzilla/show_bug.cgi?id=271419'. |
There was a problem hiding this comment.
This is a readme, I would use the short version of the header:
https://www.apache.org/legal/src-headers.html#is-a-short-form-of-the-source-header-available
| @@ -0,0 +1,387 @@ | |||
| Name: Expression Language Implementation | |||
| Description: Provides an implementation of the Expression Language (EL). | |||
| Version: 2.2.99 (Implementation version: 3.0-b07) | |||
There was a problem hiding this comment.
This fails verification, as the version string is expected verbatim in the filename. As the name refers to the implementation version, I would just use that.
- Add the license header to binaries-list and README - Fix the license.txt file - el-impl-3.0-b07.jar is a patched jar file
junichi11
force-pushed
the
module-review-libs.elimpl
branch
from
66d9c7d to
400534c
Compare
|
Fixed. |
2 participants
