[NETBEANS-731] Hide (and auto-show) menu bar in full screen mode #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it if the user moves the mouse to the top of the screen, or invokes a keyboard mnemonic.
eirikbakke
force-pushed
the
NETBEANS-731
branch
from
35d016e to
aca3143
Compare
Member
|
How confident are you of this, do you foresee any potential problems or side effects? |
Contributor
Author
|
Quite confident--I don't foresee problems, and I've tested it on both Windows and Linux (the code is not used on MacOS). |
Member
|
OK, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the menu bar in full screen mode, but allow it to be shown again automatically if the user moves the mouse to the top of the screen, or invokes a menu keyboard mnemonic. This is already the default behavior on MacOS, but not on other OSes.
Simply hiding menu bar would be a one-line change in o.n.core.windows.view.ui.MainWindow--however a fair bit of logic is needed to make the menu bar properly appear and disappear on demand. The related logic is in the separate file AutoHidingMenuBar.java. I've done quite thorough manual testing of this on Windows 10 and Ubuntu 18, including in a multi-monitor setup, in the full NetBeans IDE as well as in my NetBeans Platform application.
See https://issues.apache.org/jira/browse/NETBEANS-731 .