[NETBEANS-946] PHP 7.3 support (Flexible Heredoc and Nowdoc Syntaxes)#889
Merged
tmysik merged 2 commits intoapache:masterfrom Sep 20, 2018
Merged
Conversation
- Fix ASTPHPScanner and PHP5ColoringLexer to provide support for new syntaxes - Remove some existing unit tests because we won't provide support for the old syntax any longer - Show errors in PHP73UnhandleError when PHP version less than 7.3 is chosen - Add unit tests for the lexers, the parser, and the formatter
- Function Call Trailing Commas - List Reference Assignment
junichi11
commented
Sep 19, 2018
...a/goldenfiles/org/netbeans/modules/php/editor/lexer/PHP53FeaturesTest/lexer/heredoc_001.pass
Show resolved
Hide resolved
junichi11
commented
Sep 19, 2018
...ta/goldenfiles/org/netbeans/modules/php/editor/lexer/PHP53FeaturesTest/lexer/nowdoc_008.pass
Show resolved
Hide resolved
junichi11
commented
Sep 19, 2018
...ta/goldenfiles/org/netbeans/modules/php/editor/lexer/PHP53FeaturesTest/lexer/nowdoc_012.pass
Show resolved
Hide resolved
junichi11
commented
Sep 19, 2018
php/php.editor/test/unit/src/org/netbeans/modules/php/editor/lexer/PHP53FeaturesTest.java
Show resolved
Hide resolved
junichi11
commented
Sep 20, 2018
Member
|
Extremely cool. |
junichi11
deleted the
php7.3-support-flexible-heredoc-nowdoc-syntaxes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Flexible Heredoc and Nowdoc Syntaxes.
NOTE: Allow mixing spaces and tabs as indentation because the lexer would be complex if we handle it as errors there.
Move unit test data for "Function Call Trailing Commas" and "List Reference Assignment" to the php73 directory.