[NETBEANS-1292] Adding simple infrastructure to write Groovy Hints ba…#902
Merged
svenreimers merged 1 commit intoapache:masterfrom Sep 30, 2018
Merged
[NETBEANS-1292] Adding simple infrastructure to write Groovy Hints ba…#902svenreimers merged 1 commit intoapache:masterfrom
svenreimers merged 1 commit intoapache:masterfrom
Conversation
…sed on AST (not errors).
Member
|
Looks great and will be very useful, but I am not an expert in this area, which specific parts need to be reviewed, how confident are you about this PR, what are the possible side effects, should we merge it? |
Member
Author
|
Side effects should be small, if registration is ok nobody will notice anything, if something goes wrong we will see immediatley. Is already cooking in my daily IDE for quite some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sed on AST (not errors).