Upgrade Gradle Tooling API 9.3.0-rc-2 #9112
Draft
+108
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
added
Java
mbien
reviewed
Dec 29, 2025
| this.value = value; | ||
| this.name = propertyName; | ||
| } | ||
| public static final record Property(Object id, String scope, String name, PropertyKind kind, String type, String value) { |
Member
There was a problem hiding this comment.
nit: records are implicitly final and static
Contributor
Author
There was a problem hiding this comment.
Oh. I left that change unintentionally there. I just needed a quick and good toString() method for debugging.
Well, if it made there let's keep that, I'll just remove the static final in the upcoming commit.
Member
There was a problem hiding this comment.
its something we could also add as editor hint. I put it on my TODO list ;)
Member
|
found this in my stash as leftover of #8814 which might be needed on newer gradle versions: diff --git a/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle b/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle
index ef7b070ca4..0eff699006 100644
--- a/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle
+++ b/java/gradle.dependencies/test/unit/data/projects/multi/oci/build.gradle
@@ -31,7 +31,7 @@ java {
}
task testJar(type: Jar) {
- classifier = 'tests'
+ archiveClassifier = 'tests'
from sourceSets.test.output
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this upgrade was not that easy as I thought would be. Mostly due to the Micronaut based test projects were too old to work with Gradle 9, and when I upgraded the Micronaut plugin version some tests needed some adjustments as well.
During testing I've found some API design issues, those would be addressed later (if ever).
I think there are some Micronaut mines still out there, so I mark this one Draft till I can cover those.