Skip to content

Revert "Replace delete-artifact action with REST api calls using gh CLI"#9424

Merged
mbien merged 1 commit into
masterfrom
revert-9286-ci-replace-delete-artifact-action
Jun 2, 2026
Merged

Revert "Replace delete-artifact action with REST api calls using gh CLI"#9424
mbien merged 1 commit into
masterfrom
revert-9286-ci-replace-delete-artifact-action

Conversation

@mbien
Copy link
Copy Markdown
Member

@mbien mbien commented Jun 2, 2026

Reverts #9286

for some reason the permission is only changed to write on master, but PR workflows still have it set to read. This causes the cleanup job to fail. There might be another guard somewhere which specifically sets this permission back to read.

e.g https://github.com/apache/netbeans/actions/runs/26810081110

image

Its not clear to my why it worked back when I tested it originally.

the successful merge run for comparison:
https://github.com/apache/netbeans/actions/runs/26761144212/job/78899977569
image

@mbien mbien added this to the NB31 milestone Jun 2, 2026
@mbien mbien added the CI continuous integration changes label Jun 2, 2026
@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jun 2, 2026

this does also indicate that the actions: write permission isn't needed for the cache action otherwise we would see a failure there too.

@mbien mbien marked this pull request as ready for review June 2, 2026 13:13
@mbien
Copy link
Copy Markdown
Member Author

mbien commented Jun 2, 2026

Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: GeekyEggo/delete-artifact@f275313. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026.

ok, the original action should remain functional for about two weeks, merging.

@mbien mbien merged commit bc3c3fe into master Jun 2, 2026
29 checks passed
@neilcsmith-net
Copy link
Copy Markdown
Member

I guess we go back to #9280 pending further thought?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants