NIFI-15601 Improved the TIME_DURATION_REGEX in DurationFormat.java to accurately capture a positive decimal number with or without a leading integer.#66
Open
dan-s1 wants to merge 1 commit intoapache:mainfrom
Conversation
… accurately capture a positive decimal number with or without a leading integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15601
In order to standardize the exceptions thrown, I improved the
TIME_DURATION_REGEXregular expression inDurationFormatto capture a positive decimal number whether it has a leading integer or not and not allow for more than one period.In addition to adding unit tests to test when the duration value has illegal characters, I also added another case to an existing parameterized test
testGetPreciseTimeDurationWithDecimalNumbersto test a decimal that does not even have a leading zero.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch