Skip to content

NIFI-9404 Add NAR info, parent NAR info, and build info to extension-…#15

Closed
bbende wants to merge 2 commits intoapache:mainfrom
bbende:NIFI-9404
Closed

NIFI-9404 Add NAR info, parent NAR info, and build info to extension-…#15
bbende wants to merge 2 commits intoapache:mainfrom
bbende:NIFI-9404

Conversation

@bbende
Copy link
Contributor

@bbende bbende commented Nov 22, 2021

…manifest

@bbende bbende requested a review from markap14 November 22, 2021 21:56
@@ -550,11 +551,44 @@ private void generateDocumentation() throws MojoExecutionException {
try {
xmlWriter.writeStartElement("extensionManifest");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be some author Information in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the definition of "author" is the person that wrote the code, then no I don't think we have a way to really track this, but I did push an update that adds "builtBy" which is consistent with what we have in the MANIFEST.

@ottobackwards
Copy link

This looks pretty straight forward, I have two questions though:

  1. should there be github actions to build and lint this?
  2. How is this Information used be the registry? is it visible to the operator? Should there be information about the author included as well?

@bbende
Copy link
Contributor Author

bbende commented Nov 29, 2021

should there be github actions to build and lint this?

It was never setup for this repo since it is very low activity. I'd say it would be a follow on effort if we want to do that.

How is this Information used be the registry? is it visible to the operator? Should there be information about the author included as well?

The registry currently always has the NAR so it can obtain all this info from the MANIFEST, but I want to be able to have the same info available when only having the XML file and not having the full NAR.

@asfgit asfgit closed this in 746ebf6 Nov 30, 2021
@joewitt
Copy link
Contributor

joewitt commented Nov 30, 2021

+1 merged to main- thanks

@ottobackwards
Copy link

Sorry, I wasn't able to check my mail on this before now, thanks for answering @bbende , and thanks for doing the merge @joewitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants