NIFI-10457 Add a new goal that checks dependency duplications in nars#23
Closed
tomitheninja wants to merge 3 commits intoapache:mainfrom
Closed
NIFI-10457 Add a new goal that checks dependency duplications in nars#23tomitheninja wants to merge 3 commits intoapache:mainfrom
tomitheninja wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
Author
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the contribution @tomitheninja! This looks like a helpful new feature. I noted a few general recommendations, other reviews may be able to provide a more detailed review.
src/main/java/org/apache/nifi/NarDuplicateDependenciesMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/NarDuplicateDependenciesMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/nifi/NarDuplicateDependenciesMojo.java
Outdated
Show resolved
Hide resolved
exceptionfactory
approved these changes
Nov 22, 2022
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the changes and introducing this improvement @tomitheninja!
Building the latest version and configuring a NAR module with the duplicate-dependencies-nar goal, the plugin detected the presence of a duplicate dependency from a module where the dependency should have been marked as provided.
+1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.