NIFI-5859 - Build NAR Extension Definitions/docs at build time#8
Closed
bbende wants to merge 4 commits intoapache:masterfrom
Closed
NIFI-5859 - Build NAR Extension Definitions/docs at build time#8bbende wants to merge 4 commits intoapache:masterfrom
bbende wants to merge 4 commits intoapache:masterfrom
Conversation
…e additional details into separate file(s)
…ed logic for traversing dependencies
…h enforceDocGeneration property on plugin configuration
Contributor
|
Will review... |
kevdoran
approved these changes
Feb 13, 2019
Contributor
There was a problem hiding this comment.
+1. Verified by:
- Ran
mvn clean installon this branch - Updated NiFi to use the 1.2.1-SNAPSHOT version of this plugin
- Build NiFi and checked the resulting NARs in the
/libdirectory. Checked a few random ones to verifyMETA-INF/docswas populated.
Worked great! Nice work @bbende and @markap14. Will leave as-is for now incase it needs additional changes prior to merging. EDIT: after talking with Bryan, will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the work from #7 with some additional improvements.