MINIFICPP-1544 Add Custom Text property to GenerateFlowFile processor#1054
Closed
lordgamez wants to merge 3 commits intoapache:mainfrom
Closed
MINIFICPP-1544 Add Custom Text property to GenerateFlowFile processor#1054lordgamez wants to merge 3 commits intoapache:mainfrom
lordgamez wants to merge 3 commits intoapache:mainfrom
Conversation
lordgamez
force-pushed
the
MINIFICPP-1544
branch
from
30ffaa4 to
e3a1dbb
Compare
arpadboda
reviewed
Apr 22, 2021
Contributor
arpadboda
left a comment
arpadboda
left a comment
There was a problem hiding this comment.
Mostly looks good, two minor comments.
| std::string custom_text; | ||
| context->getProperty(CustomText, custom_text, nullptr); | ||
| if (!custom_text.empty()) { | ||
| std::copy(custom_text.begin(), custom_text.end(), std::back_inserter(data_)); |
Contributor
There was a problem hiding this comment.
data_.assign(custom_text.begin(), custom_text.end());
For me this feels like a bit shorter and more efficient, but I may missed some constraints here when using this.
lordgamez
force-pushed
the
MINIFICPP-1544
branch
from
e3a1dbb to
8b3702d
Compare
arpadboda
approved these changes
Apr 27, 2021
adamdebreceni
approved these changes
Apr 27, 2021
szaszm
approved these changes
Apr 27, 2021
martinzink
approved these changes
Apr 27, 2021
dam4rus
pushed a commit
to dam4rus/nifi-minifi-cpp
that referenced
this pull request
May 18, 2021
MINIFICPP-1544 Make GenerateFlowFileTests platform independent Signed-off-by: Arpad Boda <aboda@apache.org> This closes apache#1054
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.