MINIFICPP-1556 Fix setting partial or invalid credentials in AWS credentials service#1070
Closed
lordgamez wants to merge 4 commits intoapache:mainfrom
Closed
MINIFICPP-1556 Fix setting partial or invalid credentials in AWS credentials service#1070lordgamez wants to merge 4 commits intoapache:mainfrom
lordgamez wants to merge 4 commits intoapache:mainfrom
Conversation
When partial credentials are set for AWS it could happen that the credential files got set with the value of a previous property.
fgerlits
reviewed
May 11, 2021
arpadboda
approved these changes
May 12, 2021
adamdebreceni
approved these changes
May 12, 2021
dam4rus
pushed a commit
to dam4rus/nifi-minifi-cpp
that referenced
this pull request
May 18, 2021
Signed-off-by: Adam Debreceni <adebreceni@apache.org> This closes apache#1070
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue addressed is when partial credentials were set for AWS in the credentials service it could happen that the credential files property was set with the value of a previous property.
Another issue addressed is if the credentials in the credentials service were empty or invalid they were used in the S3 processors. Now instead the S3 processors fail before trying to use the invalid credentials.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.