Skip to content

MINIFICPP-1556 Fix setting partial or invalid credentials in AWS credentials service#1070

Closed
lordgamez wants to merge 4 commits intoapache:mainfrom
lordgamez:MINIFICPP-1556
Closed

MINIFICPP-1556 Fix setting partial or invalid credentials in AWS credentials service#1070
lordgamez wants to merge 4 commits intoapache:mainfrom
lordgamez:MINIFICPP-1556

Conversation

@lordgamez
Copy link
Contributor

The issue addressed is when partial credentials were set for AWS in the credentials service it could happen that the credential files property was set with the value of a previous property.

Another issue addressed is if the credentials in the credentials service were empty or invalid they were used in the S3 processors. Now instead the S3 processors fail before trying to use the invalid credentials.


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

lordgamez added 2 commits May 11, 2021 11:08
When partial credentials are set for AWS it could happen that the
credential files got set with the value of a previous property.
Copy link
Contributor

@fgerlits fgerlits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dam4rus pushed a commit to dam4rus/nifi-minifi-cpp that referenced this pull request May 18, 2021
Signed-off-by: Adam Debreceni <adebreceni@apache.org>

This closes apache#1070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants