MINIFICPP-1494 Allow InvokeHTTP GET requests without incoming flowfile#1082
Closed
lordgamez wants to merge 10 commits intoapache:mainfrom
Closed
MINIFICPP-1494 Allow InvokeHTTP GET requests without incoming flowfile#1082lordgamez wants to merge 10 commits intoapache:mainfrom
lordgamez wants to merge 10 commits intoapache:mainfrom
Conversation
fgerlits
reviewed
May 27, 2021
martinzink
reviewed
May 27, 2021
Comment on lines
77
to
82
| : args_(args) | ||
| , configuration_(std::make_shared<minifi::Configure>()) | ||
| , test_repo_(std::make_shared<TestRepository>()) | ||
| , test_flow_repo_(std::make_shared<TestFlowRepository>()) | ||
| , content_repo_(std::make_shared<core::repository::VolatileContentRepository>()) | ||
| , stream_factory_(minifi::io::StreamFactory::getInstance(configuration_)) { |
Member
There was a problem hiding this comment.
very minor, but I feel like the comma should be in the end of the previous lines, to comply with our style guide
https://google.github.io/styleguide/cppguide.html#Constructor_Initializer_Lists
Contributor
Author
There was a problem hiding this comment.
You are right, that was just some ad-hoc style I was used to. Fixed it in a0f1f41
| HTTPIntegrationBase::setUrl(url, handler); | ||
| } | ||
|
|
||
| void setProperties(std::shared_ptr<core::Processor> proc) { |
Contributor
There was a problem hiding this comment.
Is it necessary to increase the ref count of proc?
| const auto components = flowController_->getComponents("InvokeHTTP"); | ||
| assert(!components.empty()); | ||
|
|
||
| const auto stateController = components.at(0); |
Contributor
There was a problem hiding this comment.
This can even be accessed using [], since emptiness is checked before.
| std::shared_ptr<core::ContentRepository> content_repo = std::make_shared<core::repository::VolatileContentRepository>(); | ||
| content_repo->initialize(configuration); | ||
| std::shared_ptr<minifi::io::StreamFactory> stream_factory = minifi::io::StreamFactory::getInstance(configuration); | ||
| std::unique_ptr<core::FlowConfiguration> yaml_ptr = std::unique_ptr<core::YamlConfiguration>( |
Contributor
There was a problem hiding this comment.
Could be make_unique.
adam-markovics
approved these changes
Jun 4, 2021
fgerlits
approved these changes
Jun 8, 2021
lordgamez
force-pushed
the
MINIFICPP-1494
branch
from
7f194ba to
1a9edb8
Compare
lordgamez
force-pushed
the
MINIFICPP-1494
branch
from
1a9edb8 to
9ac3bc8
Compare
szaszm
reviewed
Jun 22, 2021
szaszm
approved these changes
Jun 22, 2021
adamdebreceni
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling the use case when InvokeHTTP processor has no real incoming connection but there is a Retry self-loop, the scheduler should trigger the processor.
Jira ticket: https://issues.apache.org/jira/browse/MINIFICPP-1494
Note: We discussed that renaming the relationships is not an option to avoid introducing a breaking change, only change (1) is implemented
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.