Skip to content

MINIFICPP-1582 fixing build failure in centos ci job#1099

Closed
martinzink wants to merge 2 commits intoapache:mainfrom
martinzink:MINIFICPP-1582
Closed

MINIFICPP-1582 fixing build failure in centos ci job#1099
martinzink wants to merge 2 commits intoapache:mainfrom
martinzink:MINIFICPP-1582

Conversation

@martinzink
Copy link
Member

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@martinzink martinzink changed the title MINIFICPP-1582 fixing build falure in centos ci job MINIFICPP-1582 fixing build failure in centos ci job Jun 4, 2021
@martinzink
Copy link
Member Author

martinzink commented Jun 4, 2021

Unfortunately this wont make the job green due to a new centos8 cmake bug. (reported today 2021.06.04)
https://bugs.centos.org/view.php?id=18212
That issue can be reproduced by a simple
docker run --interactive --tty centos:8 bash -c "yum -y install cmake && cmake" command
which also returns cmake: symbol lookup error: cmake: undefined symbol: archive_write_add_filter_zstd
If that issue is also fixed the ci job should be green.

@martinzink martinzink marked this pull request as ready for review June 4, 2021 14:07
@martinzink
Copy link
Member Author

Unfortunately this wont make the job green due to a new centos8 cmake bug. (reported today 2021.06.04)
https://bugs.centos.org/view.php?id=18212
That issue can be reproduced by a simple
docker run --interactive --tty centos:8 bash -c "yum -y install cmake && cmake" command
which also returns cmake: symbol lookup error: cmake: undefined symbol: archive_write_add_filter_zstd
If that issue is also fixed the ci job should be green.

updating the libarchive fixed the issue a21a6bf

@arpadboda arpadboda closed this in e51192e Jun 7, 2021
@martinzink martinzink deleted the MINIFICPP-1582 branch March 6, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants